Skip to content

Require pinned pynwb version again #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 7, 2025
Merged

Require pinned pynwb version again #580

merged 4 commits into from
Sep 7, 2025

Conversation

@t-b
Copy link
Collaborator

@t-b t-b commented Aug 20, 2025 •
edited
Loading

@t-b t-b self-assigned this Aug 20, 2025
@t-b
Copy link
Collaborator Author

t-b commented Aug 20, 2025

Regarding the integration tests we'll do:

Regarding the planned move to pynwb 3.2.1 for ipfx and the corresponding nwb-schema version 2.9.0 for MIES/IPNWB. Is there a test procedure with these new NWB files I should follow? The existing tests not requiring LIMS already pass locally.
I was involved in adopting NWBv2 in 2020, but we never did an schema version upgrade.
As an idea we could reexport the NWBv2 files used in test_run_feature_vector.py with the newer MIES/IPNWB version and run that test with these files as well.

Also document that procedure.

@t-b t-b force-pushed the require-fixed-pynwb-version-again branch from 90f848a to 06d87b0 Compare August 27, 2025 11:14
@t-b t-b mentioned this pull request Aug 27, 2025
Merged
2 tasks
@t-b t-b changed the title Require fixed pynwb version again Require pinned pynwb version again Sep 2, 2025
@t-b t-b mentioned this pull request Sep 5, 2025
Merged
5 tasks
t-b added 4 commits September 5, 2025 22:05
@t-b
requirements.txt: Require pynwb 3.1.2
f9bae1d 
This makes the maintenance burden smaller as both IPNWB, our
data upstream, and ipfx then use the same nwb-schema version (2.9.0).
@t-b
tests/test_run_feature_vector.py: Prefer test parametrization
9e21553 
This uses the pytest feature of test parametrization instead of just using
the global dict test_nwb2_files. This prepares for more test files in a
future commit.
@t-b
tests/test_run_feature_vector.py: Add NWB files with schema 2.9.0
5586abe 
As we are moving to a newer nwb-schema version for IPNWB and a new fixed
pynwb version for ipfx we are adopting a test design for these nwb-schema
upgrades.
@t-b
TESTING.md: Add it
5ef2f4d
@t-b t-b force-pushed the require-fixed-pynwb-version-again branch from 06d87b0 to 5ef2f4d Compare September 5, 2025 20:05
@t-b t-b requested a review from gouwens September 5, 2025 20:06
@t-b t-b assigned gouwens and unassigned t-b Sep 5, 2025
@t-b t-b merged commit 5c94fc7 into master Sep 7, 2025
12 checks passed
@t-b t-b deleted the require-fixed-pynwb-version-again branch September 7, 2025 10:32
@t-b t-b mentioned this pull request Sep 8, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gouwens gouwens gouwens approved these changes

Assignees

@gouwens gouwens

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pinning pynwb version

3 participants

@t-b @gouwens